[PATCH] D41718: [lld] Correctly link S_FILESTATIC records

Wed Jan 3 14:48:05 PST 2018

rnk added inline comments.

================
Comment at: lld/COFF/PDB.cpp:727-728
 void PDBLinker::addObjFile(ObjFile *File) {
+  static int N = 0;
+  ++N;
   // Add a module descriptor for every object file. We need to put an absolute
----------------
Unused?

================
Comment at: lld/test/COFF/Inputs/pdb-file-statics-a.yaml:13
+    Alignment:       1
+    SectionData:     04000000F1000000680000002A00011100000000443A5C7372635C6C6C766D6275696C645C636C5C44656275675C7836345C612E6F626A003A003C1101600000D00013000B00CB63000013000B00CB6300004D6963726F736F667420285229204F7074696D697A696E6720436F6D70696C657200F1000000470300000E000C117400000000000000000078002D000811611000005F5F76635F617474726962757465733A3A6576656E745F736F757263654174747269627574650039000811591000005F5F76635F617474726962757465733A3A6576656E745F736F757263654174747269627574653A3A6F7074696D697A655F650035000811561000005F5F76635F617474726962757465733A3A6576656E745F736F757263654174747269627574653A3A747970655F65003E000811521000005F5F76635F617474726962757465733A3A68656C7065725F617474726962757465733A3A76315F616C747479706541747472696275746500460008114C1000005F5F76635F617474726962757465733A3A68656C7065725F617474726962757465733A3A76315F616C74747970654174747269627574653A3A747970655F650039000811481000005F5F76635F617474726962757465733A3A68656C7065725F617474726962757465733A3A75736167654174747269627574650042000811421000005F5F76635F617474726962757465733A3A68656C7065725F617474726962757465733A3A75736167654174747269627574653A3A75736167655F65002A0008113E1000005F5F76635F617474726962757465733A3A746872656164696E674174747269627574650037000811361000005F5F76635F617474726962757465733A3A746872656164696E674174747269627574653A3A746872656164696E675F65002D000811321000005F5F76635F617474726962757465733A3A616767726567617461626C6541747472696275746500350008112A1000005F5F76635F617474726962757465733A3A616767726567617461626C654174747269627574653A3A747970655F65002F000811261000005F5F76635F617474726962757465733A3A6576656E745F726563656976657241747472696275746500370008111C1000005F5F76635F617474726962757465733A3A6576656E745F72656365697665724174747269627574653A3A747970655F650027000811181000005F5F76635F617474726962757465733A3A6D6F64756C65417474726962757465002F0008110A1000005F5F76635F617474726962757465733A3A6D6F64756C654174747269627574653A3A747970655F650000F400000018000000010000001001108D915B38B79821EA2169DBD317C2590000F60000001000000000000000031000000000000006000000F30000004900000000643A5C7372635C6C6C766D6275696C645C636C5C64656275675C7836345C612E63707000443A5C7372635C6C6C766D6275696C645C636C5C44656275675C7836345C612E6F626A00000000F10000000800000006004C116B100000
+    Subsections:
----------------
We can delete the SectionData for `.debug$S` sections.

================
Comment at: lld/test/COFF/pdb-file-static.yaml:56
+    Subsections:
+      - !Symbols
+        Records:
----------------
Does this really work? It looks like you deleted all the symbols but you still have relocations against the symbols you deleted.

https://reviews.llvm.org/D41718