[PATCH] D40961: [ARM] Fix PR35481

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 02:55:18 PST 2018

chill added inline comments.

Comment at: lib/Target/ARM/Thumb1FrameLowering.cpp:618
+  if (STI.useR7AsFramePointer())
+    PopFriendly.set(ARM::R7);
efriedma wrote:
> If you want exactly the set r0...r7, shouldn't you just set that, rather than getting the set of allocatable registers and adding back specific registers?  That would simplify the code a bit because findTemporariesForLR would be guaranteed to succeed.
I'd prefer to not depend (or depends less) on which registers are considered allocatable and contain this decision in `ARMBaseRegisterInfo::getReservedRegs` - to deal with platform specific conventions, possible future options like GCC's `-ffixed-reg-N`, etc.
That said, I'd like to add back in a similar manner r6/BasePtr.


More information about the llvm-commits mailing list