[PATCH] D40961: [ARM] Fix PR35481

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 12:10:02 PST 2018


efriedma added inline comments.


================
Comment at: lib/Target/ARM/Thumb1FrameLowering.cpp:618
+  if (STI.useR7AsFramePointer())
+    PopFriendly.set(ARM::R7);
+
----------------
If you want exactly the set r0...r7, shouldn't you just set that, rather than getting the set of allocatable registers and adding back specific registers?  That would simplify the code a bit because findTemporariesForLR would be guaranteed to succeed.


https://reviews.llvm.org/D40961





More information about the llvm-commits mailing list