[PATCH] D41334: [CodeExtractor] Use function attributes from original function.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 13:26:15 PST 2018

fhahn added a comment.

In https://reviews.llvm.org/D41334#965905, @aemerson wrote:

> What about the `noreturn `attribute? Obviously the extracted function must include a return so it seems this would need to be dropped.

Right, the part that does not return may not get extracted and would be executed after the call to the extracted function. So we should drop it, thanks! Are there any additional attributes we should be dropping?


More information about the llvm-commits mailing list