[PATCH] D41334: [CodeExtractor] Use function attributes from original function.
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 2 09:22:36 PST 2018
aemerson added a comment.
In https://reviews.llvm.org/D41334#965887, @fhahn wrote:
> Post holiday ping. Happy new year! This updates CodeExtractor to propagate the function attributes for the original function to the extracted function (and the call to the extracted function). As the extracted function is a subset of the original function, I think that should be safe and desired (e.g. correctly preserving fastmath flags or ARM thumbness)
What about the `noreturn `attribute? Obviously the extracted function must include a return so it seems this would need to be dropped.
More information about the llvm-commits