[PATCH] D41619: [llvm-objcopy] Use physical instead of virtual address when aligning and placing sections in binary

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 13:02:08 PST 2018

jakehehrlich added a comment.

In https://reviews.llvm.org/D41619#966100, @owenpshaw wrote:

> Still learning the process here, so let me know how you'd like to proceed.  I really only opened this to get a discussion going because there wasn't activity on the bug after a week or so...maybe too impatient, after all it was the holidays :)

Eh, I'm not really to clear on this either. I probably should have moved discussion about the proper solution here instead of letting it continue on bugzilla.

> So I'm fine closing this review if we want to focus discussion over on the bug since it has more information now.  I'm also fine leaving this open if its a handy way to review new patches.

No need for that. This is an issue that needs to be fixed and this is where that review should happen.

> I agree we shouldn't violate the spec, but also I still think there should be some fix for this bare metal use case and for gnu compatibility.

After your digging in the bfd code I think I'm happy with changing the binary layout algorithm to use PAddr instead of VAddr but I want the ELF layout to explicitly use VAddr. I want the VAddr alignment property to obviously hold.


More information about the llvm-commits mailing list