[PATCH] D41619: [llvm-objcopy] Use physical instead of virtual address when aligning and placing sections in binary

Owen Shaw via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 12:52:27 PST 2018

owenpshaw added a comment.

Still learning the process here, so let me know how you'd like to proceed.  I really only opened this to get a discussion going because there wasn't activity on the bug after a week or so...maybe too impatient, after all it was the holidays :)

So I'm fine closing this review if we want to focus discussion over on the bug since it has more information now.  I'm also fine leaving this open if its a handy way to review new patches.

I agree we shouldn't violate the spec, but also I still think there should be some fix for this bare metal use case and for gnu compatibility.


More information about the llvm-commits mailing list