[PATCH] D41659: Implementing missing trigonometric optimizations

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 03:06:58 PST 2018


fhahn added a comment.

Thanks for your patch!

Usually it is easier to review smaller patches. Splitting it up into 4 patches for the 4 different cases you implemented would make it slightly easier to reason about the 4 unrelated transformation in isolation.


Repository:
  rL LLVM

https://reviews.llvm.org/D41659





More information about the llvm-commits mailing list