[PATCH] D41659: Implementing missing trigonometric optimizations
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 2 02:51:27 PST 2018
asb added reviewers: majnemer, craig.topper.
asb added a comment.
As mentioned in llvm-dev, it looks like David Majnemer and Craig Topper might be appropriate reviewers for this patch (or can perhaps help to suggest other reviewers).
It looks like you've run clang-format on the entire lib/Transforms/InstCombine/InstructionCombining.cpp file. This makes it harder to review the changes you've made. Best practice is to only clang-format lines that you touch. I use the git-clang-format helper script for this, and it looks like clang-format-diff.py can help if you're using SVN:
More information about the llvm-commits