[PATCH] D40969: [DAG] Elide overlapping stores

[Nemanja Ivanovic via llvm-commits]

Hi Chandler,
thanks for bringing attention to this. I'm not sure what happened to the
email thread and why it doesn't show up on the revision now, but Nirav had
responded to my comment and committed a fix within an hour or two of me
adding the comment. The bots went back to green after that.

Thanks,
Nemanja

On Fri, Dec 29, 2017 at 3:54 PM, Chandler Carruth via Phabricator <
reviews at reviews.llvm.org> wrote:

> chandlerc added subscribers: nemanjai, chandlerc.
> chandlerc added a comment.
>
> There was a comment by @nemanjai on the submitted revision in phab that I
> think got lost:
>
> In https://reviews.llvm.org/rL321089#229740, @nemanjai wrote:
>
> > This has broken all the PowerPC buildbots. I'll pull this patch to get
> the bots back to green unless you have a fix available. The smallest
> failing benchmark from the test-suite is `sieve.c`.
> >  This patch removes half of the pre-inc stores that are actually needed.
> I imagine that the DAGCombiner is getting rid of these stores before they
> become pre-inc stores since there's a check for unindexed stores as part of
> this patch, but I haven't spent the time to really understand what this
> patch does.
> >  I'm attaching both the IR generated for `sieve.c` as well as a
> bugpoint-reduced version of it (the reduction was done by comparing the
> number of pre-inc stores emitted before the patch and after it).F5703558:
> sieve.ll <https://reviews.llvm.org/F5703558>
> >
> > F5703557: reduced.ll <https://reviews.llvm.org/F5703557>
>
>
> Notably, all PPC bots were broken by this, and it has stayed in tree for a
> long time. we should get it reverted.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D40969
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171229/8b75a7e9/attachment.html>