[PATCH] D40893: [PowerPC] fix a bug in TCO eligibility check

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/CodeGen/PowerPC/ppc64-sibcall.ll:44
 
+define internal fastcc void @callee_64_64_copy_fastcc([8 x i64] %a, [8 x i64] %b) #0 { ret void }
+define void @caller_64_64_copy_ccc([8 x i64] %a, [8 x i64] %b) #1 {
----------------
We aren't super strict about formatting in test cases, but please move the right brace to the next line.


================
Comment at: test/CodeGen/PowerPC/ppc64-sibcall.ll:45
+define internal fastcc void @callee_64_64_copy_fastcc([8 x i64] %a, [8 x i64] %b) #0 { ret void }
+define void @caller_64_64_copy_ccc([8 x i64] %a, [8 x i64] %b) #1 {
+  tail call fastcc void @callee_64_64_copy_fastcc([8 x i64] %a, [8 x i64] %b)
----------------
Please add a comment as to why we don't want to tail call here.


https://reviews.llvm.org/D40893