[PATCH] D41549: Detemplate reportDuplicate

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu accepted this revision.
> ruiu added a comment.
>
> LGTM
>
>
>
> ================
> Comment at: ELF/InputFiles.cpp:104
> +  switch (Config->EKind) {
> +  default:
> +    llvm_unreachable("Invalid kind");
> ----------------
> I think we usually write `default` at end of switch.

Interesting. Is that your preference? I normally find it a bit more
readable to have it at the start.

Cheers,
Rafael