ruiu accepted this revision. ruiu added a comment. LGTM ================ Comment at: ELF/InputFiles.cpp:104 + switch (Config->EKind) { + default: + llvm_unreachable("Invalid kind"); ---------------- I think we usually write `default` at end of switch. https://reviews.llvm.org/D41549