[PATCH] D41567: Add NO_EXEC_STACK_DIRECTIVE to chkstk and chkstk2 sources

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 24 12:50:56 PST 2017


martell added a subscriber: mstorsjo.
martell added a comment.

We should probably change the guard for AARCH64 from MINGW to WIN32.

  if (MINGW)
    set(aarch64_SOURCES
        ${aarch64_SOURCES}
        aarch64/chkstk.S)
  endif()

but will leave that for @mstorsjo to decide.

hmm looking at the #define for NO_EXEC_STACK_DIRECTIVE
once the two files have been removed from non windows targets they won't do anything anymore.

Do you have commit access, it looks good as is?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D41567





More information about the llvm-commits mailing list