[PATCH] D41567: Add NO_EXEC_STACK_DIRECTIVE to chkstk and chkstk2 sources

[Dimitry Andric via Phabricator via llvm-commits]

dim updated this revision to Diff 128117.
dim added a comment.

Oops, checked in wrong revision. This has both fixes:

- Add NO_EXEC_STACK_DIRECTIVE, that can never hurt
- Remove chkstk*.S from non-Windows targets


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D41567

Files:
  lib/builtins/CMakeLists.txt
  lib/builtins/aarch64/chkstk.S
  lib/builtins/i386/chkstk.S
  lib/builtins/i386/chkstk2.S
  lib/builtins/x86_64/chkstk.S
  lib/builtins/x86_64/chkstk2.S


Index: lib/builtins/x86_64/chkstk2.S
===================================================================
--- lib/builtins/x86_64/chkstk2.S
+++ lib/builtins/x86_64/chkstk2.S
@@ -40,3 +40,6 @@
 END_COMPILERRT_FUNCTION(__alloca)
 
 #endif // __x86_64__
+
+NO_EXEC_STACK_DIRECTIVE
+
Index: lib/builtins/x86_64/chkstk.S
===================================================================
--- lib/builtins/x86_64/chkstk.S
+++ lib/builtins/x86_64/chkstk.S
@@ -37,3 +37,6 @@
 END_COMPILERRT_FUNCTION(___chkstk_ms)
 
 #endif // __x86_64__
+
+NO_EXEC_STACK_DIRECTIVE
+
Index: lib/builtins/i386/chkstk2.S
===================================================================
--- lib/builtins/i386/chkstk2.S
+++ lib/builtins/i386/chkstk2.S
@@ -38,3 +38,6 @@
 END_COMPILERRT_FUNCTION(_alloca)
 
 #endif // __i386__
+
+NO_EXEC_STACK_DIRECTIVE
+
Index: lib/builtins/i386/chkstk.S
===================================================================
--- lib/builtins/i386/chkstk.S
+++ lib/builtins/i386/chkstk.S
@@ -32,3 +32,6 @@
 END_COMPILERRT_FUNCTION(__chkstk_ms)
 
 #endif // __i386__
+
+NO_EXEC_STACK_DIRECTIVE
+
Index: lib/builtins/aarch64/chkstk.S
===================================================================
--- lib/builtins/aarch64/chkstk.S
+++ lib/builtins/aarch64/chkstk.S
@@ -32,3 +32,6 @@
 END_COMPILERRT_FUNCTION(__chkstk)
 
 #endif // __aarch64__
+
+NO_EXEC_STACK_DIRECTIVE
+
Index: lib/builtins/CMakeLists.txt
===================================================================
--- lib/builtins/CMakeLists.txt
+++ lib/builtins/CMakeLists.txt
@@ -232,8 +232,6 @@
 
 if (NOT MSVC)
   set(x86_64_SOURCES
-      x86_64/chkstk.S
-      x86_64/chkstk2.S
       x86_64/floatdidf.c
       x86_64/floatdisf.c
       x86_64/floatdixf.c
@@ -253,8 +251,6 @@
   set(i386_SOURCES
       i386/ashldi3.S
       i386/ashrdi3.S
-      i386/chkstk.S
-      i386/chkstk2.S
       i386/divdi3.S
       i386/floatdidf.S
       i386/floatdisf.S


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41567.128117.patch
Type: text/x-patch
Size: 1927 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171224/91c19b40/attachment.bin>