[PATCH] D41393: Allow to apply cherry-picks when building Docker images.

[Eric Liu via Phabricator via llvm-commits]

ioeric added inline comments.


================
Comment at: utils/docker/scripts/build_install_llvm.sh:185
+# Sort cherrypicks and remove duplicates.
+CHERRYPICKS="$(echo "$CHERRYPICKS" | xargs -n1 | sort | uniq | xargs)"
+
----------------
I'd do the sorting in `apply_cherrypicks`. 


================
Comment at: utils/docker/scripts/build_install_llvm.sh:207
+
+  apply_cherrypicks "$CLANG_BUILD_DIR/src/$LLVM_PROJECT"
 done
----------------
IIUC,`$CHERRYPICKS` is a list of cherries for all llvm sub-projects, and we try applying them on each project, even if some of them might not apply for certain projects. Is this safe with svn? Might worth a comment. 


https://reviews.llvm.org/D41393