[PATCH] D41393: Allow to apply cherry-picks when building Docker images.

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 02:12:21 PST 2017


ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.


================
Comment at: utils/docker/scripts/build_install_llvm.sh:84
+
+  for CHERRY_REV in $CHERRYPICKS; do
+    echo "Cherry-picking r$CHERRY_REV into $CHECKOUT_DIR"
----------------
ioeric wrote:
> Do we want to sort the "cherries" in case they are not ordered? Does the order matter?
Good point. Applying them in the sorted order is the most natural choice.
Now sorting cherrypicks and removing duplicates before applying them.


https://reviews.llvm.org/D41393





More information about the llvm-commits mailing list