[PATCH] D41212: [llvm-objcopy] Add option to add a progbits section from a file
Jake Ehrlich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 14 15:53:48 PST 2017
jakehehrlich added inline comments.
================
Comment at: tools/llvm-objcopy/Object.h:129
+class RawDataSection : public SectionBase {
+private:
----------------
jhenderson wrote:
> I'm not convinced about the name of the class - how is it different from a Section? It's primarily because the data is owned, isn't it?
>
> Perhaps OwnedDataSection? What do you think?
Yep the point is that it owns the data. That seems like a better name. I'll switch it to that.
Repository:
rL LLVM
https://reviews.llvm.org/D41212
More information about the llvm-commits
mailing list