[PATCH] D41212: [llvm-objcopy] Add option to add a progbits section from a file

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Test case?



================
Comment at: tools/llvm-objcopy/Object.h:129
 
+class RawDataSection : public SectionBase {
+private:
----------------
I'm not convinced about the name of the class - how is it different from a Section? It's primarily because the data is owned, isn't it?

Perhaps OwnedDataSection? What do you think?


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:116
+static cl::list<std::string> AddSection("add-section",
+                                       cl::desc("Make a section named <section> with the contents of <file>."),
+                                       cl::value_desc("section=file"));
----------------
Has this line been clang-formatted? It looks quite long.


Repository:
  rL LLVM

https://reviews.llvm.org/D41212