[PATCH] D41100: [llvm-objcopy] Refactor llvm-objcopy to allow llvm-strip to differ

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

This change as-is looks fine to me, except for the previously highlighted issue of incompatibility in the positional arguments between the two. If you're working on splitting it up, I think it's best to wait to see what comes out before I review this further.



================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:334-335
+  Config.Keep.insert(std::end(Config.Keep), std::begin(Keep), std::end(Keep));
+  Config.OnlyKeep.insert(std::end(Config.OnlyKeep), std::begin(OnlyKeep), std::end(OnlyKeep));
+  Config.ToRemove.insert(std::end(Config.ToRemove), std::begin(ToRemove), std::end(ToRemove));
+  if(!SplitDWO.empty())
----------------
This needs clang-formatting.


Repository:
  rL LLVM

https://reviews.llvm.org/D41100