[PATCH] D41100: [llvm-objcopy] Refactor llvm-objcopy to allow llvm-strip to differ

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:326
+template <class ELFT>
+void CommonConfig(CopyConfig<ELFT>& Config) {
+  if (OutputFilename.empty())
----------------
jhenderson wrote:
> It feels to me like this should be a member of the CopyConfig class. Maybe even part of the constructor. Is there ever a case you can imagine when you would NOT want to call CommonConfig?
Nope, I think it will always be called. Also I'm currently working on splitting this up into two separate binaries instead of using this symlink hack. This is going to go in a common .o file that both will use. Good idea.


Repository:
  rL LLVM

https://reviews.llvm.org/D41100