[PATCH] D41180: [dsymutil] Re-enable threading

[Davide Italiano via Phabricator via llvm-commits]

davide requested changes to this revision.
davide added inline comments.
This revision now requires changes to proceed.


================
Comment at: test/tools/dsymutil/X86/alias.test:2
 # RUN: llvm-dsymutil -f -oso-prepend-path=%p/../Inputs/alias \
-# RUN: %p/../Inputs/alias/foobar -o - 2>&1 | llvm-dwarfdump - | FileCheck %s
+# RUN: %p/../Inputs/alias/foobar -o - | llvm-dwarfdump - 2>&1 | FileCheck %s
 # CHECK-NOT: could not find object file symbol for symbol
----------------
do you really need to use a relative path here?
Also, do you need `-o -` even thoughh you're piping to another tool?


================
Comment at: tools/dsymutil/dsymutil.cpp:416
+        LinkLambda(OS);
       } else {
+        Threads.async(LinkLambda, OS);
----------------
you don't need the braces around the else as well.


https://reviews.llvm.org/D41180