[PATCH] D41180: [dsymutil] Re-enable threading

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

seems good to me but I'm not very familiar with Threadpool.



================
Comment at: test/tools/dsymutil/ARM/fat-threading.test:3
+# RUN: llvm-dsymutil -no-output %p/../Inputs/fat-test.arm.dylib -o %t.brief.dSYM 2>&1
+# RUN: llvm-dsymutil -verify %p/../Inputs/fat-test.arm.dylib -o %t.verify.dSYM 2>&1
+
----------------
Can you add a comment explaining what is being tested here? It's non-obvious because the a casual reader might not know that we spawn one thread per arch.


================
Comment at: tools/dsymutil/dsymutil.cpp:414
       // want this limitation when we only have a single thread.
       if (NumThreads == 1) {
+        LinkLambda(OS);
----------------
remove extra `{`


https://reviews.llvm.org/D41180