[PATCH] D41126: [SelectionDAG] Fixed f16-from-vector promotion problem

[Tim Renouf via Phabricator via llvm-commits]

tpr added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:1977
 // STORE promotion handlers.
 SDValue DAGTypeLegalizer::PromoteFloatRes_BITCAST(SDNode *N) {
+  // If the bitcast is between scalar and v1 (in either direction), we need to
----------------
tpr wrote:
> arsenm wrote:
> > I don't think here should be encountering a v1* anything. i.e. getTypeAction(v1f16) should not be a TypePromoteFloat?
> OK, thanks, I'll have a look at that.
getTypeAction(v1f16) is TypeScalarizeVector, but it is still getting here.


https://reviews.llvm.org/D41126