[PATCH] D41126: [SelectionDAG] Fixed f16-from-vector promotion problem

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/unpack-half.ll:9
+
+define amdgpu_gs void @main(i32 inreg) local_unnamed_addr #0 {
+.entry:
----------------
tpr wrote:
> arsenm wrote:
> > instnamer and check something
> Do you think I need to check something even though the point of this test is to check that the compiler does not get a fatal error?
> 
> What do you mean "instnamer"?
Usually tests without checks are frowned upon. For this it should reduce down to maybe one conversion instruction and the store.

Run the pass instnamer on the test. I don't like committing tests with anonymous values since it makes them harder to modify in the future. 


https://reviews.llvm.org/D41126