[PATCH] D40782: [tablegen] Add !codeconcat operator which works like !strconcat

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 22:18:24 PST 2017


hfinkel added inline comments.


================
Comment at: lib/TableGen/Record.cpp:766
 
-static StringInit *ConcatStringInits(const StringInit *I0,
-                                     const StringInit *I1) {
+template <class T> static T *ConcatStringInits(const T *I0, const T *I1) {
   SmallString<80> Concat(I0->getValue());
----------------
Maybe call this ConcatStringLikeInits or ConcatInits? It should be renamed now that it is not specific to StringInits.


https://reviews.llvm.org/D40782





More information about the llvm-commits mailing list