[llvm] r320464 - [ThinLTO] Remove unused code from thinLTOInternalizeModule

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 01:12:33 PST 2017


Author: evgeny777
Date: Tue Dec 12 01:12:32 2017
New Revision: 320464

URL: http://llvm.org/viewvc/llvm-project?rev=320464&view=rev
Log:
[ThinLTO] Remove unused code from thinLTOInternalizeModule

Differential revision: https://reviews.llvm.org/D40970

Modified:
    llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp

Modified: llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp?rev=320464&r1=320463&r2=320464&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp Tue Dec 12 01:12:32 2017
@@ -642,23 +642,9 @@ void llvm::thinLTOResolveWeakForLinkerMo
 /// Run internalization on \p TheModule based on symmary analysis.
 void llvm::thinLTOInternalizeModule(Module &TheModule,
                                     const GVSummaryMapTy &DefinedGlobals) {
-  // Parse inline ASM and collect the list of symbols that are not defined in
-  // the current module.
-  StringSet<> AsmUndefinedRefs;
-  ModuleSymbolTable::CollectAsmSymbols(
-      TheModule,
-      [&AsmUndefinedRefs](StringRef Name, object::BasicSymbolRef::Flags Flags) {
-        if (Flags & object::BasicSymbolRef::SF_Undefined)
-          AsmUndefinedRefs.insert(Name);
-      });
-
   // Declare a callback for the internalize pass that will ask for every
   // candidate GlobalValue if it can be internalized or not.
   auto MustPreserveGV = [&](const GlobalValue &GV) -> bool {
-    // Can't be internalized if referenced in inline asm.
-    if (AsmUndefinedRefs.count(GV.getName()))
-      return true;
-
     // Lookup the linkage recorded in the summaries during global analysis.
     auto GS = DefinedGlobals.find(GV.getGUID());
     if (GS == DefinedGlobals.end()) {




More information about the llvm-commits mailing list