[PATCH] D40893: [PowerPC] fix a bug in TCO eligibility check
Hiroshi Inoue via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 11 23:15:49 PST 2017
inouehrs added a comment.
> Can you also update the patch description? One inline request as well. You can also handle the inline request as a separate commit.
I updated the description.
About the URL in the comment, it is an example of a case where GCC can do sibling call optimization even with a byval parameter rather tan an additional explanation on why this is a workaround; the example is too large to embed in a comment.
How about changing `See: https://...` to `GCC can do such sibling call optimization such as https://...` or just remove `See: https://...`? Any preference?
Anyway I like to touch up this comment later in another patch.
https://reviews.llvm.org/D40893
More information about the llvm-commits
mailing list