[PATCH] D40893: [PowerPC] fix a bug in TCO eligibility check
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 11 13:33:24 PST 2017
echristo added a comment.
In https://reviews.llvm.org/D40893#950338, @inouehrs wrote:
> combined with r319218 "[PowerPC] Allow tail calls of fastcc functions from C CallingConv functions."
Can you also update the patch description? One inline request as well. You can also handle the inline request as a separate commit.
Thanks!
-eric
================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:4442
// caller's stack size > callee's stack size, we are still able to apply
// sibling call optimization. See: https://reviews.llvm.org/D23441#513574
if (any_of(Outs, [](const ISD::OutputArg& OA) { return OA.Flags.isByVal(); }))
----------------
Since you're here can you update this with the actual problem and not an external link? We don't really do that.
https://reviews.llvm.org/D40893
More information about the llvm-commits
mailing list