[PATCH] D40802: [MemDep] Don't use cached results from a previous larger query

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 08:03:53 PST 2017


sunfish updated this revision to Diff 125731.
sunfish added a comment.

This adds a fix for the testcase reported in PR35519; see the change in MemCpyOptimizer.cpp. The code for merging stores into a memset wasn't properly updating memdep's query cache.

This isn't ready for final review yet:

- I plan to add a reduced testcase. (It's complex to write as the bug requires a specific sequence of events -- one optimization happens in a way that leaves the cache in an incorrect state, then a second optimization relies on the cache).
- I plan to address @sanjoy's review feedback.


Repository:
  rL LLVM

https://reviews.llvm.org/D40802

Files:
  lib/Analysis/MemoryDependenceAnalysis.cpp
  lib/Transforms/Scalar/MemCpyOptimizer.cpp
  test/Transforms/MemCpyOpt/mixed-sizes.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40802.125731.patch
Type: text/x-patch
Size: 4557 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171206/f57fbd87/attachment.bin>


More information about the llvm-commits mailing list