[PATCH] D40802: [MemDep] Don't use cached results from a previous larger query

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy requested changes to this revision.
sanjoy added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:1129
   if (!Pair.second) {
-    if (CacheInfo->Size < Loc.Size) {
-      // The query's Size is greater than the cached one. Throw out the
-      // cached data and proceed with the query at the greater size.
+    if (CacheInfo->Size != Loc.Size) {
+      // The query's Size differs from the cached one. Throw out the
----------------
You can still use the result if `CacheInfo->Size` is UnknownSize, right?

And, secondly, any reason to not add the size to the cache key as well?


Repository:
  rL LLVM

https://reviews.llvm.org/D40802