[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In https://reviews.llvm.org/D38406#945888, @MatzeB wrote:

> In https://reviews.llvm.org/D38406#945869, @bogner wrote:
>
> > In https://reviews.llvm.org/D38406#945845, @hintonda wrote:
> >
> > > My solution would support buildbots, developer builds, and installed versions via llvm-config.
> >
> >
> > I don't understand how this version supports installed versions, the define doesn't appear in llvm-config at all here. Can you explain?
>
>
> While I could see an `llvm-config` solution working, I'd really rather see us try the llvm-config.h solution first. In my experience people who do not come from a unix/linux background usually setup their own projects in various IDEs and do not profit from an llvm-config tool feeding them the right flags, they would have to discover the right flags themselfes if they aren't in llvm-config.h.


I can do this, but I got a lot of push back from multiple people at the dev meeting when I floated this idea, so I didn't pursue it.  The complaint seemed to be multiple files and -I directives would be too confusing.  Btw, we'll have to munge the command line variables based on the config.  I'll give it a try and get back to you.


https://reviews.llvm.org/D38406