[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

[Justin Bogner via Phabricator via llvm-commits]

bogner added a comment.

In https://reviews.llvm.org/D38406#945892, @hintonda wrote:

> I was planning on using llvm-config, e.g.:
>
>   local:/Users/dhinton/projects/llvm_project/build/Debug $ bin/llvm-config --cxxflags
>   -I/Users/dhinton/projects/llvm_project/llvm/include -I/Users/dhinton/projects/llvm_project/build/Debug/include  -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics -O3  -DLLVM_ENABLE_DUMP  -fno-exceptions -fno-rtti -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
>


Ah, that llvm-config. Sorry, I got confused about that and llvm-config.h.

This sort of works, but I don't think it's optimal. Most users of llvm as a library I'm aware of don't use `llvm-config --cxxflags` (though they often do use other llvm-config flags). This command lists a number of flags that you don't necessarily want when building against llvm (like the specific warning settings).


https://reviews.llvm.org/D38406