[PATCH] D40291: [Support] Add WritableMemoryBuffer class

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 14:32:26 PST 2017


I advocated for const-ifying ArrayRef when MutableArrayRef was added (so
const all the existing ArrayRef, and then have non-const ArrayRef for when
mutation is desired - avoiding the need to introduce an explicit
MutableArrayRef type) but Chris wasn't a fan of that, so we have ArrayRef +
MutableArrayRef (the argument being that most ArrayRefs are const, so
making the more common case more verbose was unfavorable)

I believe in that case MutableArrayRef has an implicit conversion operator
to ArrayRef (or ArrayRef has a conversion from MutableArrayRef, I forget
which) & expect we could do the same thing here, to be consistent?

- Dave

On Mon, Dec 4, 2017 at 9:00 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added a comment.
>
> Hi David,
>
> could you look at this by any chance?
>
> thanks.
>
>
> https://reviews.llvm.org/D40291
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171204/88657a0f/attachment.html>


More information about the llvm-commits mailing list