[PATCH] D39348: Implement --just-symbols.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 18:02:24 PST 2017


Rui Ueyama via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> ruiu marked 5 inline comments as done.
> ruiu added inline comments.
>
>
> ================
> Comment at: lld/ELF/InputFiles.cpp:1055
> +template <class ELFT>
> +std::vector<std::pair<StringRef, uint64_t>>
> +elf::readSymbols(MemoryBufferRef MB) {
> ----------------
> mcgrathr wrote:
>> The canonical semantics are to copy all the other fields as well, not just st_value.
>> Only st_shndx is replaced with SHN_ABS.  The others are preserved (size, visibility, type, etc.).
>> 
> Yeah that's true, but I wonder if real programs depend on it.

Visibility might have an impact in what relaxations get applied, but
that does sound fairly contrived.

Roland, do you have a use case in mind for anything but the names?

Cheers,
Rafael


More information about the llvm-commits mailing list