[PATCH] D39348: Implement --just-symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu marked 5 inline comments as done.
ruiu added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:1055
+template <class ELFT>
+std::vector<std::pair<StringRef, uint64_t>>
+elf::readSymbols(MemoryBufferRef MB) {
----------------
mcgrathr wrote:
> The canonical semantics are to copy all the other fields as well, not just st_value.
> Only st_shndx is replaced with SHN_ABS.  The others are preserved (size, visibility, type, etc.).
> 
Yeah that's true, but I wonder if real programs depend on it.


https://reviews.llvm.org/D39348