[PATCH] D40103: [libFuzzer] Encapsulate commands in a class

[Aaron Green via Phabricator via llvm-commits]

aarongreen updated this revision to Diff 125235.
aarongreen marked 4 inline comments as done.
aarongreen added a comment.

Holidays, illnesses, and more have kept me from closing on this; apologies.

Yes, kcc, this change is supposed maintain functional equivalence.  It should only provide a more convenient way to build processes from commands without having to do a bunch of string parsing.

I've tried to go through and match the style guide <https://llvm.org/docs/CodingStandards.html>. I'm still familiarizing myself with that one, please correct me if I'm not compliant. I also added the unit tests.  Finally, I changed ExecuteCommand to take a Command rather than a string since the change was small enough that I don't think it warrants a separate review.

Thanks for the review!


https://reviews.llvm.org/D40103

Files:
  lib/fuzzer/CMakeLists.txt
  lib/fuzzer/FuzzerCommand.h
  lib/fuzzer/FuzzerDriver.cpp
  lib/fuzzer/FuzzerMerge.cpp
  lib/fuzzer/FuzzerUtil.h
  lib/fuzzer/FuzzerUtilDarwin.cpp
  lib/fuzzer/FuzzerUtilLinux.cpp
  lib/fuzzer/FuzzerUtilWindows.cpp
  lib/fuzzer/tests/FuzzerUnittest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40103.125235.patch
Type: text/x-patch
Size: 21510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171201/e385ba49/attachment.bin>