[PATCH] D40289: [SafepointIRVerifier] Allow deriving pointers from unrelocated base

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 09:42:22 PST 2017


anna accepted this revision.
anna added a comment.

thanks for making the changes. lgtm with a minor comment.



================
Comment at: lib/IR/SafepointIRVerifier.cpp:311
+/// FIXME: type of BBContributionUpdater is a template parameter because it
+/// might be a lambda with arbitrary non-empty capture list. It's ugly a bit and
+/// unclear. So this function, TransferBlock, TransferInstruction and others
----------------
Could you pls phrase it as:
"FIXME: It's a bit ugly and unclear, but other options causes us to spread the logic of `RecalculateBBStates` across the rest of the algorithm." This will nicely flow with the rest of the comment about encapsulating everything in  a class.


https://reviews.llvm.org/D40289





More information about the llvm-commits mailing list