[PATCH] D40363: [AArch64][SVE] Asm: Improve diagnostics further when +sve is not specified
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 29 09:10:01 PST 2017
fhahn added inline comments.
================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2800
// Emit check that the required features are available.
OS << " // check if the available features match\n";
----------------
I think we should clarify here who's responsibility is to print the error message when ParseForAllFeatures = true.
Also, ` if (!ParseForAllFeatures && (AvailableFeatures & it->RequiredFeatures!= it->RequiredFeatures) {`?
https://reviews.llvm.org/D40363
More information about the llvm-commits
mailing list