[PATCH] D40363: [AArch64][SVE] Asm: Improve diagnostics further when +sve is not specified

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 09:04:15 PST 2017


fhahn added reviewers: echristo, efriedma.
fhahn added a comment.

Thanks Sander. IMO this is a nice improvement to the error messages and not SVE specific. Could you update the title & description? The only potential issue I can think about the same assembler string being enabled by multiple target features. What would happen in that case? The worst thing that can happen is only printing 1 of the target features to enable it?

Also adding Eric & Eli, as they might have some thoughts on this.


https://reviews.llvm.org/D40363





More information about the llvm-commits mailing list