[PATCH] D40530: Factor out common code to Common/Strings.cpp.

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama <ruiu at google.com> writes:

> Moving the MSVC demangler wrapper is for symmetry. Before this patch, we
> have `lld::coff::demangle` and `lld::elf::demangle`. Just renaming
> lld::elf::demangle lld::demangle is ambiguous, so I had to rename it
> lld::demangleItanium. Now we have several choices on what to do to the MSVC
> demangler.
>
>   1. lld::demangleItanium and lld::coff::demangle
>   2. lld::demangleItanium and lld::coff::demangleMSVC
>   3. lld::demangleItanium and lld::demangleMSVC
>
> The first two choices feel a bit inconsistent, so I chose the last one.

If we had a full implementation of the msvc demangler I would go with 3.

Given that the msvc demangler just uses UnDecorateSymbolName, there is
an asymmetry already and I think 2 is the best option.

Cheers,
Rafael