[PATCH] D40530: Factor out common code to Common/Strings.cpp.

[Rui Ueyama via llvm-commits]

On Mon, Nov 27, 2017 at 4:54 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

>
> Moving the itanium demangler to Common makes sense since it is used by
> various formats and can be built everywhere.
>
> I am not sure of the value of moving the msvc demangler. It is only used
> by COFF and can only be built on windows.
>

Moving the MSVC demangler wrapper is for symmetry. Before this patch, we
have `lld::coff::demangle` and `lld::elf::demangle`. Just renaming
lld::elf::demangle lld::demangle is ambiguous, so I had to rename it
lld::demangleItanium. Now we have several choices on what to do to the MSVC
demangler.

  1. lld::demangleItanium and lld::coff::demangle
  2. lld::demangleItanium and lld::coff::demangleMSVC
  3. lld::demangleItanium and lld::demangleMSVC

The first two choices feel a bit inconsistent, so I chose the last one.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171127/b7da6963/attachment.html>