[PATCH] D40360: [AArch64][SVE] Asm: Add SVE predicate register definitions and parsing support

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 22 09:31:34 PST 2017


fhahn added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:852
+
+  template <int ElementWidth> bool isSVEPredicateRegOfWidth() const {
+    return isSVEPredicateReg() &&
----------------
nit: would it be enough to just have isSVERegOfWidth() that works for both predicate and data SVE registers? One less template :)


https://reviews.llvm.org/D40360





More information about the llvm-commits mailing list