[PATCH] D40291: [Support] Add WritableMemoryBuffer class

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 10:09:51 PST 2017


I'm honestly not sure.  But, if there's not an immediate use case for them,
I wouldn't mind removing them until someone needs them.

On Tue, Nov 21, 2017 at 10:06 AM Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Zachary Turner <zturner at google.com> writes:
>
> > A MutableMemoryBuffer need not be backed by mmap.  For example, you could
> > just allocate some scratch bytes from the heap.  Allowing something like
> > this to work with the same interface as an mmap is one of the primary
> > advantages IMO, because it means you don't have to have different code
> > paths for mmap and malloc.
>
> I agree. What about RequiresNullTerminator and IsVolatile? Do you need
> to expose them?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171121/8b6d05f7/attachment.html>


More information about the llvm-commits mailing list