[PATCH] D40206: [x86][icelake]vbmi2

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 22:45:26 PST 2017


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrAVX512.td:9871
+                           avx512vl_i16_info>, VEX_W;
+  defm D : vbmi2_pmadd52_rmb_common<dqOpc, OpStrPrefix##"d", OpNode,
+                                    avx512vl_i32_info>;
----------------
craig.topper wrote:
> If you're going to reuse the pmadd class, I'd really prefer you rename it.
Oops I meant to remove this after I wrote the other comment about not reusing pmadd


Repository:
  rL LLVM

https://reviews.llvm.org/D40206





More information about the llvm-commits mailing list