[PATCH] D40206: [x86][icelake]vbmi2

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrAVX512.td:9857
+  let Predicates = [HasVBMI2] in
+  defm Z  : vbmi2_pmadd52_rm<Op, OpStr, OpNode, VTI.info512>,
+              EVEX_V512, EVEX_CD8<VTI.info512.EltSize, CD8VF>;
----------------
Don't reuse the pmadd52 classes. I don't think its worth the complexity to make it do what you need here.


================
Comment at: lib/Target/X86/X86InstrAVX512.td:9871
+                           avx512vl_i16_info>, VEX_W;
+  defm D : vbmi2_pmadd52_rmb_common<dqOpc, OpStrPrefix##"d", OpNode,
+                                    avx512vl_i32_info>;
----------------
If you're going to reuse the pmadd class, I'd really prefer you rename it.


Repository:
  rL LLVM

https://reviews.llvm.org/D40206