[PATCH] D29938: [RISCV 16/n] Support and tests for a variety of additional LLVM IR constructs

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:206
+
+  // TODO: should also handle gp-relative loads
+
----------------
Period after comment.


================
Comment at: lib/Target/RISCV/RISCVInstrInfo.td:332
+// Define pattern expansions for setcc operations that aren't directly
+// handled by a RISC-V instruction
+def : Pat<(seteq GPR:$rs1, GPR:$rs2), (SLTIU (XOR GPR:$rs1, GPR:$rs2), 1)>;
----------------
Period after comment.


https://reviews.llvm.org/D29938