[PATCH] D38566: [SimplifyCFG] don't sink common insts too soon (PR34603)

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 11:23:06 PST 2017


davide added a comment.

Until ~ 1 year ago, SimplifyCFG was a single pass, and everything was fine (and IMHO, that's how it should be).
Then we found out it had bad interactions with inlining, so we decided to split in two passes. That's OK, as long as it's una tantum.
Keeping adding knobs to tweak the 4-5 different SimplifyCFG invocations in-tree is a slippery rope.


https://reviews.llvm.org/D38566





More information about the llvm-commits mailing list