[PATCH] D38566: [SimplifyCFG] don't sink common insts too soon (PR34603)

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 11:18:42 PST 2017


davide added a comment.

The proliferation of `cl::opt`(s) maybe hints SimplifyCFG is growing a little too much? & might need to be split in separate passes.
SimplifyCFG is a pretty fundamental canonicalization pass & should be almost free to run. For sinking, we have a separate pass, so maybe it's worth taking a look at whether that's fixable instead of patching SimplifyCFG behaviour? I really would like to prevent SimplifyCFG to become the next Instcombine.


https://reviews.llvm.org/D38566





More information about the llvm-commits mailing list