[PATCH] D40034: [DAGCombine] Enable more srl + load combines

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 01:28:14 PST 2017


SjoerdMeijer added a comment.

Hi Sam, that's a very nice optimisation, but I think we need more tests.  The "variables" that we have here are the values types (load byte, load half, load word), and the different possible offsets.  Guessing a bit here, but that must be something like 3 * 3(?)  = 9 tests.
And another question is how this interacts with -munaligned-access and -mno-unaligned-access?


https://reviews.llvm.org/D40034





More information about the llvm-commits mailing list